Using Trail Of Bits Fix Review, responded to the initial report
$ claude
❯ /fix-review v0.8.1-beta develop --report ChainSecurity_Ammalgam_DLEX_audit_V2_draft.pdf
❯ # Bug Introduction Response
1. The report looks like it does not take into account the burn and withdraw pattern
requiring the user to transfer DEPOSIT_L token to the pair before burn triggering the
execution of `validateOnUpdate()` which updates saturation, also the same for
DEPOSIT_X and DEPOSIT_Y tokens.
2. Accept Risk, 1 day is not enough time at extreme amounts of interest to produce
concerns.
# Still Open Responses
- CS-019 Missing assets are now done on the fly in `missingAssets()` so there is
nothing to recalculate
- CS-020 recordObservation was modifed in 17fa46 to record a more sever price then
the depletion price to put pressure on borrowers that would lead to liquidations of
the debts that would resolve depletion. See test `Cantina319_PoC`
- CS-021 See commit 85735c and commit message explaining the fixes
- CS-022 See commit 13aead and commit message explaining the fixes
- CS-023 Was not called out in a commit but was addressed in changes to Fragile
Liquidity including refactoring tranche size 07f6a5 and described in gh issue #1049
- CS-024 See test `fuzz_testRecursiveBorrowMaxBorrow` that shows the impact of the
changes.
- CS-026 fixed in commit 440388
- CS-027 fixed in commit 941074
- CS-028 synced 1inch library in commit e2d620